Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editorial] Maximum number of visible points #4566

Merged
merged 15 commits into from
Jun 30, 2024
Merged

[Editorial] Maximum number of visible points #4566

merged 15 commits into from
Jun 30, 2024

Conversation

brebenelmihnea
Copy link
Contributor

@brebenelmihnea brebenelmihnea commented Jun 29, 2024 •
edited
Loading

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

@brebenelmihnea brebenelmihnea requested a review from dongliuu as a code owner June 29, 2024 18:33
SansPapyrus683
SansPapyrus683 approved these changes Jun 29, 2024
View reviewed changes
Copy link
Contributor

@SansPapyrus683 SansPapyrus683 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is fine, need someone to look @ expl lol

ryanchou-dev
ryanchou-dev reviewed Jun 30, 2024
View reviewed changes
Copy link
Member

@ryanchou-dev ryanchou-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than this looks good

@ryanchou-dev ryanchou-dev enabled auto-merge June 30, 2024 20:39
@ryanchou-dev ryanchou-dev merged commit 5935827 into cpinitiative:master Jun 30, 2024
3 checks passed
@brebenelmihnea brebenelmihnea deleted the maximum-number-of-visible-points branch June 30, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SansPapyrus683 SansPapyrus683 SansPapyrus683 approved these changes

@dongliuu dongliuu Awaiting requested review from dongliuu dongliuu is a code owner

@ryanchou-dev ryanchou-dev Awaiting requested review from ryanchou-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brebenelmihnea @SansPapyrus683 @ryanchou-dev